non-admin user acess with usergroup #15489
Conversation
amolpati30
added
CherryPick
amolpati30
force-pushed
the
non-admin_permission
branch
2 times, most recently
from
8387a61 to
5a8daf2
Compare
amolpati30
force-pushed
the
non-admin_permission
branch
from
5a8daf2 to
fb88a4f
Compare
tests/foreman/ui/test_ansible.py
Outdated
| u_name = gen_string('alpha') | ||
| ug_name = gen_string('alpha') | ||
| password = gen_string('alpha') | ||
| user = target_sat.api.User(login=u_name, password=password, admin=False).create() |
There was a problem hiding this comment.
Can you use gen_string('alpha') here directly instead of u_name and use user.login in test below? and same for usergroup?
There was a problem hiding this comment.
Used gen_string('alpha') directly instead of creating a new variable for user and usergroup.
tests/foreman/ui/test_ansible.py
Outdated
| wait_for(lambda: session.browser.refresh(), timeout=5) | ||
| ansible_roles_table = session.host_new.get_ansible_roles(target_sat.hostname) | ||
| assert ansible_roles_table[0]['Name'] == SELECTED_ROLE | ||
| request.addfinalizer(user.delete) |
There was a problem hiding this comment.
can you move this finalizer to the top immediately after user is created?
There was a problem hiding this comment.
After creating the user, the finalizer was used
tests/foreman/ui/test_ansible.py
Outdated
| ansible_roles_table = session.host_new.get_ansible_roles(target_sat.hostname) | ||
| assert ansible_roles_table[0]['Name'] == SELECTED_ROLE | ||
| request.addfinalizer(user.delete) | ||
| assert user.login == u_name |
There was a problem hiding this comment.
| assert user.login == u_name |
There was a problem hiding this comment.
Removed this line.
tests/foreman/ui/test_ansible.py
Outdated
| ug_name = gen_string('alpha') | ||
| password = gen_string('alpha') | ||
| user = target_sat.api.User(login=u_name, password=password, admin=False).create() | ||
| target_sat.api.UserGroup(name=ug_name, user=[user], admin=True).create() |
There was a problem hiding this comment.
can we verify is user is part of usergroup after usergroup is created?
There was a problem hiding this comment.
assertion is added that user is part of usergroup
tests/foreman/ui/test_ansible.py
Outdated
| result = target_sat.cli.Auth.logout() | ||
| assert 'Logged out' in result |
There was a problem hiding this comment.
Can we remove this as UI session will login with created user?
There was a problem hiding this comment.
Removed this unnecessary logout line
tests/foreman/ui/test_ansible.py
Outdated
| @@ -519,6 +519,43 @@ def test_positive_assign_and_remove_ansible_role_to_hostgroup( | |||
| session.hostgroup.delete(name) | |||
| assert not target_sat.api.HostGroup().search(query={'search': f'name={name}'}) | |||
|
|
|||
| @pytest.mark.tier3 | |||
| def test_positive_non_admin_access( | |||
There was a problem hiding this comment.
can we change this test name to something meaningful?
There was a problem hiding this comment.
The test name has been changed.
Gauravtalreja1
added
the
QETestCoverage
amolpati30
force-pushed
the
non-admin_permission
branch
from
fb88a4f to
f069dd2
Compare
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
the
PRT-Failed
|
trigger: test-robottelo |
|
"trigger": "test-robottelo" |
|
PRT Result |
Satellite-QE
added
PRT-Passed
|
"trigger": "test-robottelo" |
|
PRT Result |
non-admin user acess with usergroup (#15489) Bump tenacity from 8.4.2 to 8.5.0 (#15587) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 070b1dc) Co-authored-by: amolpati30 <[email protected]>
Bump tenacity from 8.4.2 to 8.5.0 (SatelliteQE#15587) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Problem Statement
With user which is non-admin but it is in usergroup which should give him administrator role is possible to access lot of pages, but giving Permission denied
Solution
It verifies if a non-admin user in the user group can access the WebUI.
Dependent PR: SatelliteQE/airgun#1461